gsl: CVE-2020-35357

Debian Bug report logs - #1052655
gsl: CVE-2020-35357

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Salvatore Bonaccorso <carnil@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: gsl: CVE-2020-35357

Date: Mon, 25 Sep 2023 20:58:34 +0200

Source: gsl
Version: 2.7.1+dfsg-5
Severity: important
Tags: security upstream
Forwarded: https://savannah.gnu.org/bugs/?59624
X-Debbugs-Cc: carnil@debian.org, Debian Security Team <team@security.debian.org>
Control: found -1 2.6+dfsg-2

Hi,

The following vulnerability was published for gsl.

CVE-2020-35357[0]:
| A buffer overflow can occur when calculating the quantile value
| using the Statistics Library of GSL (GNU Scientific Library),
| versions 2.5 and 2.6. Processing a maliciously crafted input data
| for gsl_stats_quantile_from_sorted_data of the library may lead to
| unexpected application termination or arbitrary code execution.


If you fix the vulnerability please also make sure to include the
CVE (Common Vulnerabilities & Exposures) id in your changelog entry.

For further information see:

[0] https://security-tracker.debian.org/tracker/CVE-2020-35357
    https://www.cve.org/CVERecord?id=CVE-2020-35357
[1] https://savannah.gnu.org/bugs/?59624
[2] https://git.savannah.gnu.org/cgit/gsl.git/commit/?id=989a193268b963aa1047814f7f1402084fb7d859

Regards,
Salvatore

Message #12 received at 1052655@bugs.debian.org (full text, mbox, reply):

From: Dirk Eddelbuettel <edd@debian.org>

To: Salvatore Bonaccorso <carnil@debian.org>, 1052655@bugs.debian.org

Cc: Dirk Eddelbuettel <edd@debian.org>

Subject: Re: Bug#1052655: gsl: CVE-2020-35357

Date: Tue, 26 Sep 2023 06:54:31 -0500

On 25 September 2023 at 20:58, Salvatore Bonaccorso wrote:
| Source: gsl
| Version: 2.7.1+dfsg-5
           ^^^^^^^^^^^^
| Severity: important
| Tags: security upstream
| Forwarded: https://savannah.gnu.org/bugs/?59624
| X-Debbugs-Cc: carnil@debian.org, Debian Security Team <team@security.debian.org>
| Control: found -1 2.6+dfsg-2
| 
| Hi,
| 
| The following vulnerability was published for gsl.
| 
| CVE-2020-35357[0]:
| | A buffer overflow can occur when calculating the quantile value
| | using the Statistics Library of GSL (GNU Scientific Library),
| | versions 2.5 and 2.6. Processing a maliciously crafted input data
             ^^^^^^^^^^^^

I presume this is still true?  Is the '2020' in the CVE for the year this is from?

[ I see now at [0] that is spreads 2.6 and 2.7.  Out of curiousity, who did
the fix for buster (security) and when ? ]



| | for gsl_stats_quantile_from_sorted_data of the library may lead to
| | unexpected application termination or arbitrary code execution.
| 
| 
| If you fix the vulnerability please also make sure to include the
| CVE (Common Vulnerabilities & Exposures) id in your changelog entry.

I'll try. I think this is only the second CVE case in my nearly 30 years in Debian.

So the debian/changelog entry needs to contain the string 'CVE-2020-35357' -- correct?

Dirk

| For further information see:
| 
| [0] https://security-tracker.debian.org/tracker/CVE-2020-35357
|     https://www.cve.org/CVERecord?id=CVE-2020-35357
| [1] https://savannah.gnu.org/bugs/?59624
| [2] https://git.savannah.gnu.org/cgit/gsl.git/commit/?id=989a193268b963aa1047814f7f1402084fb7d859
| 
| Regards,
| Salvatore

-- 
dirk.eddelbuettel.com | @eddelbuettel | edd@debian.org

Message #17 received at 1052655@bugs.debian.org (full text, mbox, reply):

From: Salvatore Bonaccorso <carnil@debian.org>

To: Dirk Eddelbuettel <edd@debian.org>

Cc: 1052655@bugs.debian.org

Subject: Re: Bug#1052655: gsl: CVE-2020-35357

Date: Tue, 26 Sep 2023 14:19:27 +0200

Hi Dirk,

On Tue, Sep 26, 2023 at 06:54:31AM -0500, Dirk Eddelbuettel wrote:
> 
> On 25 September 2023 at 20:58, Salvatore Bonaccorso wrote:
> | Source: gsl
> | Version: 2.7.1+dfsg-5
>            ^^^^^^^^^^^^
> | Severity: important
> | Tags: security upstream
> | Forwarded: https://savannah.gnu.org/bugs/?59624
> | X-Debbugs-Cc: carnil@debian.org, Debian Security Team <team@security.debian.org>
> | Control: found -1 2.6+dfsg-2
> | 
> | Hi,
> | 
> | The following vulnerability was published for gsl.
> | 
> | CVE-2020-35357[0]:
> | | A buffer overflow can occur when calculating the quantile value
> | | using the Statistics Library of GSL (GNU Scientific Library),
> | | versions 2.5 and 2.6. Processing a maliciously crafted input data
>              ^^^^^^^^^^^^
> 
> I presume this is still true?  Is the '2020' in the CVE for the year this is from?

I did check the source and unless I did a mistake in checking then yes
the issue is unfixed up to 2.7.1+dfsg-5 yet, and [2] applies.

> [ I see now at [0] that is spreads 2.6 and 2.7.  Out of curiousity, who did
> the fix for buster (security) and when ? ]

For buster: https://tracker.debian.org/news/1465169/accepted-gsl-25dfsg-6deb10u1-source-into-oldoldstable/

> | | for gsl_stats_quantile_from_sorted_data of the library may lead to
> | | unexpected application termination or arbitrary code execution.
> | 
> | 
> | If you fix the vulnerability please also make sure to include the
> | CVE (Common Vulnerabilities & Exposures) id in your changelog entry.
> 
> I'll try. I think this is only the second CVE case in my nearly 30 years in Debian.

Thanks. Note the issue does not really warrant a DSA, I had two goals
with filling the bug: make you aware of the CVE assignment so the
issue can be fixed first in unstable and the fix land in trixie. For
bookworm and bullseye if you have spare cycles the fix might land in a
point release (there is one upcoming, but the window for uploads
closing the upcoming weekend).

> So the debian/changelog entry needs to contain the string 'CVE-2020-35357' -- correct?

Yes that is good.

Regards,
Salvatore

Message #22 received at 1052655@bugs.debian.org (full text, mbox, reply):

From: Dirk Eddelbuettel <edd@debian.org>

To: Dirk Eddelbuettel <edd@debian.org>

Cc: Salvatore Bonaccorso <carnil@debian.org>, 1052655@bugs.debian.org

Subject: Re: Bug#1052655: gsl: CVE-2020-35357

Date: Tue, 26 Sep 2023 07:41:55 -0500

Fix made, built, uploaded and committed to the package's salsa repo.

Dirk

-- 
dirk.eddelbuettel.com | @eddelbuettel | edd@debian.org

Message #27 received at 1052655@bugs.debian.org (full text, mbox, reply):

From: Dirk Eddelbuettel <edd@debian.org>

To: Salvatore Bonaccorso <carnil@debian.org>

Cc: Dirk Eddelbuettel <edd@debian.org>, 1052655@bugs.debian.org

Subject: Re: Bug#1052655: gsl: CVE-2020-35357

Date: Tue, 26 Sep 2023 07:53:35 -0500

Hi Salvatore,

Looks like we emailed concurrently :)  (or concurrently enough for my batched
mail setup).

On 26 September 2023 at 14:19, Salvatore Bonaccorso wrote:
| Hi Dirk,
| 
| On Tue, Sep 26, 2023 at 06:54:31AM -0500, Dirk Eddelbuettel wrote:
| > 
| > On 25 September 2023 at 20:58, Salvatore Bonaccorso wrote:
| > | Source: gsl
| > | Version: 2.7.1+dfsg-5
| >            ^^^^^^^^^^^^
| > | Severity: important
| > | Tags: security upstream
| > | Forwarded: https://savannah.gnu.org/bugs/?59624
| > | X-Debbugs-Cc: carnil@debian.org, Debian Security Team <team@security.debian.org>
| > | Control: found -1 2.6+dfsg-2
| > | 
| > | Hi,
| > | 
| > | The following vulnerability was published for gsl.
| > | 
| > | CVE-2020-35357[0]:
| > | | A buffer overflow can occur when calculating the quantile value
| > | | using the Statistics Library of GSL (GNU Scientific Library),
| > | | versions 2.5 and 2.6. Processing a maliciously crafted input data
| >              ^^^^^^^^^^^^
| > 
| > I presume this is still true?  Is the '2020' in the CVE for the year this is from?
| 
| I did check the source and unless I did a mistake in checking then yes
| the issue is unfixed up to 2.7.1+dfsg-5 yet, and [2] applies.

I found (thanks to your diligent links) the better upstream fix that will be
in 2.8 and used that.

| > [ I see now at [0] that is spreads 2.6 and 2.7.  Out of curiousity, who did
| > the fix for buster (security) and when ? ]
| 
| For buster: https://tracker.debian.org/news/1465169/accepted-gsl-25dfsg-6deb10u1-source-into-oldoldstable/

Ack. And that was only days ago so I wasn't asleep at the wheel here.

| > | | for gsl_stats_quantile_from_sorted_data of the library may lead to
| > | | unexpected application termination or arbitrary code execution.
| > | 
| > | 
| > | If you fix the vulnerability please also make sure to include the
| > | CVE (Common Vulnerabilities & Exposures) id in your changelog entry.
| > 
| > I'll try. I think this is only the second CVE case in my nearly 30 years in Debian.
| 
| Thanks. Note the issue does not really warrant a DSA, I had two goals

Agreed.

| with filling the bug: make you aware of the CVE assignment so the
| issue can be fixed first in unstable and the fix land in trixie. For
| bookworm and bullseye if you have spare cycles the fix might land in a
| point release (there is one upcoming, but the window for uploads
| closing the upcoming weekend).

I am a bit on the fence as to whether it is needed but I suppose the change
in -6 would apply 'as is'.
 
| > So the debian/changelog entry needs to contain the string 'CVE-2020-35357' -- correct?
| 
| Yes that is good.

Perfect. I used that.

Cheers, Dirk

-- 
dirk.eddelbuettel.com | @eddelbuettel | edd@debian.org

Message #32 received at 1052655@bugs.debian.org (full text, mbox, reply):

From: Salvatore Bonaccorso <carnil@debian.org>

To: Dirk Eddelbuettel <edd@debian.org>

Cc: 1052655@bugs.debian.org

Subject: Re: Bug#1052655: gsl: CVE-2020-35357

Date: Tue, 26 Sep 2023 16:19:29 +0200

Hi Dirk,

On Tue, Sep 26, 2023 at 07:53:35AM -0500, Dirk Eddelbuettel wrote:
> 
> Hi Salvatore,
> 
> Looks like we emailed concurrently :)  (or concurrently enough for my batched
> mail setup).
> 
> On 26 September 2023 at 14:19, Salvatore Bonaccorso wrote:
> | Hi Dirk,
> | 
> | On Tue, Sep 26, 2023 at 06:54:31AM -0500, Dirk Eddelbuettel wrote:
> | > 
> | > On 25 September 2023 at 20:58, Salvatore Bonaccorso wrote:
> | > | Source: gsl
> | > | Version: 2.7.1+dfsg-5
> | >            ^^^^^^^^^^^^
> | > | Severity: important
> | > | Tags: security upstream
> | > | Forwarded: https://savannah.gnu.org/bugs/?59624
> | > | X-Debbugs-Cc: carnil@debian.org, Debian Security Team <team@security.debian.org>
> | > | Control: found -1 2.6+dfsg-2
> | > | 
> | > | Hi,
> | > | 
> | > | The following vulnerability was published for gsl.
> | > | 
> | > | CVE-2020-35357[0]:
> | > | | A buffer overflow can occur when calculating the quantile value
> | > | | using the Statistics Library of GSL (GNU Scientific Library),
> | > | | versions 2.5 and 2.6. Processing a maliciously crafted input data
> | >              ^^^^^^^^^^^^
> | > 
> | > I presume this is still true?  Is the '2020' in the CVE for the year this is from?
> | 
> | I did check the source and unless I did a mistake in checking then yes
> | the issue is unfixed up to 2.7.1+dfsg-5 yet, and [2] applies.
> 
> I found (thanks to your diligent links) the better upstream fix that will be
> in 2.8 and used that.

Ack thanks!

> | > [ I see now at [0] that is spreads 2.6 and 2.7.  Out of curiousity, who did
> | > the fix for buster (security) and when ? ]
> | 
> | For buster: https://tracker.debian.org/news/1465169/accepted-gsl-25dfsg-6deb10u1-source-into-oldoldstable/
> 
> Ack. And that was only days ago so I wasn't asleep at the wheel here.
> 
> | > | | for gsl_stats_quantile_from_sorted_data of the library may lead to
> | > | | unexpected application termination or arbitrary code execution.
> | > | 
> | > | 
> | > | If you fix the vulnerability please also make sure to include the
> | > | CVE (Common Vulnerabilities & Exposures) id in your changelog entry.
> | > 
> | > I'll try. I think this is only the second CVE case in my nearly 30 years in Debian.
> | 
> | Thanks. Note the issue does not really warrant a DSA, I had two goals
> 
> Agreed.
> 
> | with filling the bug: make you aware of the CVE assignment so the
> | issue can be fixed first in unstable and the fix land in trixie. For
> | bookworm and bullseye if you have spare cycles the fix might land in a
> | point release (there is one upcoming, but the window for uploads
> | closing the upcoming weekend).
> 
> I am a bit on the fence as to whether it is needed but I suppose the change
> in -6 would apply 'as is'.

ok. Yes at least for stable the thing is straightforward anyway.
>  
> | > So the debian/changelog entry needs to contain the string 'CVE-2020-35357' -- correct?
> | 
> | Yes that is good.
> 
> Perfect. I used that.

Great. One other thing which could have been done is to close the bug
along (as the BTS can close a bug as well with multiple versions it is
not needed to keep it open until as well fixed in stable and
oldstable, it can simply be closed with each version in turn).

Thanks for your work and swift repsonses!

Regards,
Salvatore

Message #37 received at 1052655-done@bugs.debian.org (full text, mbox, reply):

From: Dirk Eddelbuettel <edd@debian.org>

To: Salvatore Bonaccorso <carnil@debian.org>

Cc: Dirk Eddelbuettel <edd@debian.org>, 1052655-done@bugs.debian.org

Subject: Re: Bug#1052655: gsl: CVE-2020-35357

Date: Tue, 26 Sep 2023 09:40:36 -0500

On 26 September 2023 at 16:19, Salvatore Bonaccorso wrote:
| Great. One other thing which could have been done is to close the bug
| along (as the BTS can close a bug as well with multiple versions it is
| not needed to keep it open until as well fixed in stable and
| oldstable, it can simply be closed with each version in turn).

Flim. I forgot as I was so much in 'CVE' mode. I usually do that quite
religiously.

CCing -done now (and in case that is 'too global', my bad once more -- please
tweak at the BTS to your liking as I will consider this now taken care of).
 
| Thanks for your work and swift repsonses!

My pleasure. It was a breeze given the excellent pointers you provided,
particularly to the better upstream fix.

Cheers, Dirk

-- 
dirk.eddelbuettel.com | @eddelbuettel | edd@debian.org

Send a report that this bug log contains spam.